Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version v12.9.3 RC #29358

Merged
merged 8 commits into from
Dec 20, 2024
Merged

Version v12.9.3 RC #29358

merged 8 commits into from
Dec 20, 2024

Conversation

metamaskbot
Copy link
Collaborator

📦 🚀

@metamaskbot metamaskbot added the team-bot Bot team (for MetaMask Bot) label Dec 19, 2024
@metamaskbot
Copy link
Collaborator Author

Builds ready [9e42c34]
Page Load Metrics (1709 ± 62 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28920031561437210
domContentLoaded14891989167212359
load15012002170912862
domInteractive268139188
backgroundConnect884332311
firstReactRender176931188
getState46518189
initialActions01000
loadScripts1025139012039847
setupStore675162010
uiStartup17382275189713866

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

This PR cherry picks
#29343
@metamaskbot
Copy link
Collaborator Author

Builds ready [317b923]
Page Load Metrics (1520 ± 37 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1399168615217737
domContentLoaded1391164215036933
load1399168815207637
domInteractive22111342010
backgroundConnect75718167
firstReactRender1573322211
getState44110105
initialActions01000
loadScripts1003123710986431
setupStore6509105
uiStartup1555182816787837

matthewwalsh0 and others added 2 commits December 20, 2024 13:55
…ions #29341 (#29397)

## **Description**

Cherry-pick of #29341 for release 12.9.3.

Difference to `main` is that redesigned transactions are disabled if the
`Decode smart contracts` toggle is disabled.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29397?quickstart=1)

## **Related issues**

## **Manual testing steps**

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Cherry pick 0e10bab (#29268) to v12.9.3

Co-authored-by: Alejandro Garcia Anglada <[email protected]>
Co-authored-by: MetaMask Bot <[email protected]>
Copy link

socket-security bot commented Dec 20, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 57.1 kB ai

🚮 Removed packages: npm/[email protected]

View full report↗︎

@metamaskbot
Copy link
Collaborator Author

Builds ready [611f3bb]
Page Load Metrics (1607 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28319671478404194
domContentLoaded13861952158312560
load14031970160712761
domInteractive23133452813
backgroundConnect67823189
firstReactRender1570462110
getState45012136
initialActions01000
loadScripts10121584118913062
setupStore64813146
uiStartup15622123178012761

…req is triggered from an iframe #29337  (#29405)

Chery pick PR: #29337 into `V12.9.3`

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution? -->

See the attached issue in metamask planning for more details.

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29337?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to `https://develop.d3bkcslj57l47p.amplifyapp.com/`
2. Click on Proceed anyways (This phishing warning page here is
expected)
3. Open the network tab to monitor network requests
4. Connect your wallet and click on a signature or transaction
5. Verify that mainFrameOrigin is included in the payload of the network
request to the security alerts API

<img width="1727" alt="Screenshot 2024-12-20 at 10 46 05 AM"
src="https://github.com/user-attachments/assets/71a0868d-21cf-4ce2-af20-11f092beb2ce"
/>

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

Below are screenshots demonstrating the behavior of a test HTML page I
created:

1. In the first screenshot, before the iframe is loaded, the console
shows only the origin of the main frame.
2. In the second screenshot, after clicking the button to load an iframe
pointing to example.com, the solution correctly identifies both the
mainFrameOrigin (main frame) and the origin (iframe).

<img width="1728" alt="Screenshot 2024-12-18 at 10 24 48 PM"
src="https://github.com/user-attachments/assets/244a1f9a-a0c1-4c82-b89e-8b20a8238d8e"
/>


<img width="1728" alt="Screenshot 2024-12-18 at 10 24 54 PM"
src="https://github.com/user-attachments/assets/ac28aacd-ec4a-4fd0-b644-8564345ea3d4"
/>




### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
@metamaskbot
Copy link
Collaborator Author

Builds ready [5069950]
Page Load Metrics (1742 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23520601588455218
domContentLoaded14591964170312359
load14832107174214268
domInteractive2211133199
backgroundConnect6232405024
firstReactRender1787512211
getState496192411
initialActions01000
loadScripts10511455125310953
setupStore636963
uiStartup16622462197619795

@danjm
Copy link
Contributor

danjm commented Dec 20, 2024

@metamaskbot update-attributions

@metamaskbot
Copy link
Collaborator Author

Attributions updated

@danjm danjm marked this pull request as ready for review December 20, 2024 21:52
@danjm danjm requested review from a team as code owners December 20, 2024 21:52
@metamaskbot
Copy link
Collaborator Author

Builds ready [19635b4]
Page Load Metrics (1599 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14091823160112460
domContentLoaded14021769158311856
load14071782159912259
domInteractive18195443919
backgroundConnect76819188
firstReactRender1673392411
getState46413188
initialActions01000
loadScripts9941307115310148
setupStore67213168
uiStartup15911981178612862

@danjm danjm merged commit 2e0fe07 into master Dec 20, 2024
80 of 81 checks passed
@danjm danjm deleted the Version-v12.9.3 branch December 20, 2024 22:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-bot Bot team (for MetaMask Bot)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants